Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

findNvim should work without $PATH #267

Open
justinmk opened this issue Dec 3, 2023 · 0 comments
Open

findNvim should work without $PATH #267

justinmk opened this issue Dec 3, 2023 · 0 comments

Comments

@justinmk
Copy link
Member

justinmk commented Dec 3, 2023

Problem

findNvim currently depends on $PATH. That makes it less useful for GUIs where the $PATH may be missing some common nvim install locations. https://github.com/neovim/node-client/pull/207/files#r1265953052

Expected behavior

Search for nvim in common locations, e.g.

/usr/local/bin/
/usr/bin
/opt/homebrew/bin
/home/linuxbrew/.linuxbrew/bin
$HOME/.linuxbrew/bin
$HOME/bin

as well as any others that we possibly can, such as the install locations for https://github.com/microsoft/winget-cli and https://scoop.sh/ on Windows, if possible.

Also...

Capture time cost for each search step and report that in the result? https://github.com/neovim/node-client/pull/207/files#r1264587700

@justinmk justinmk changed the title getNvimFromEnv should work without $PATH findNvim should work without $PATH Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant