Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jenkins-workspace tasks don't work on existing workers #3732

Closed
targos opened this issue May 20, 2024 · 1 comment · Fixed by #3733
Closed

jenkins-workspace tasks don't work on existing workers #3732

targos opened this issue May 20, 2024 · 1 comment · Fixed by #3733
Labels
ansible

Comments

@targos
Copy link
Member

targos commented May 20, 2024

Even after #3722, it fails at this step:

TASK [jenkins-workspace : Initialize Git repository] *******************************************************************
fatal: [test-equinix-ubuntu2204-x64-2]: FAILED! => {"changed": false, "cmd": "/usr/bin/git clone --bare https://github.com/nodejs/node /home/binary_tmp/binary_tmp.git", "msg": "Cloning into bare repository '/home/binary_tmp/binary_tmp.git'...\nfatal: Invalid path '/home/iojs/build': Permission denied", "rc": 128, "stderr": "Cloning into bare repository '/home/binary_tmp/binary_tmp.git'...\nfatal: Invalid path '/home/iojs/build': Permission denied\n", "stderr_lines": ["Cloning into bare repository '/home/binary_tmp/binary_tmp.git'...", "fatal: Invalid path '/home/iojs/build': Permission denied"], "stdout": "", "stdout_lines": []}
@targos targos added the ansible label May 20, 2024
@richardlau
Copy link
Member

I think a lot of this weirdness is coming from

build/ansible/roles/jenkins-workspace/tasks/main.yml

Lines 42 to 43 in 97b592a

# Repository needs to be created in /home/iojs/build because the partition with
# free space might be mounted in a way that does not include /home/binary_tmp

which means we're trying to create a git repository owned by binary_tmp into a directory under the home for a different user, iojs.

For the current machines, the comment about partitions only applies to the IBM hosted machine where the bigger disk is mounted at /home/iojs. I'm not sure why we couldn't mount the disk at /home instead and then just create the git repository under the home directory of the binary_tmp user.

@richardlau richardlau mentioned this issue May 20, 2024
Merged
richardlau added a commit that referenced this issue May 23, 2024
@richardlau
ansible: create git repo under binary_tmp user (#3733)
f5167c7 
Create the `binary_tmp` git repository under the home directory for
the `binary_tmp` user to avoid permissions issues encountered when
previously trying to create it under the `iojs` user.

This change will mean that for any machines that mount expanded
storage as an additional disk, the `binary_tmp` users' home directory
will need to be on the larger storage. In practice this means that
the additional disk should be mounted at `/home/` rather than
`/home/iojs/`.

Fixes: #3732
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ansible
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ansible: create git repo under binary_tmp user richardlau/build
2 participants
@targos @richardlau