Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid Commit Message #117

Open
H4ad opened this issue Oct 4, 2023 · 1 comment
Open

Invalid Commit Message #117

H4ad opened this issue Oct 4, 2023 · 1 comment

Comments

@H4ad
Copy link
Member

H4ad commented Oct 4, 2023

This PR was merged with a non-imperative verb starting the commit message: benchmark: added new benchmarks for blob.

From what the docs says, it should be a invalid message.

The CI did raised an error about the length (that I fix) but didn't raise an error about this verb and it was merged.

@tniessen
Copy link
Member

tniessen commented Oct 5, 2023

It is extremely difficult to automatically and reliably determine whether a commit message follows our commit message guidelines exactly. In the end, it is the collaborators' responsibility to only merge commits that follow the guidelines.

@tniessen tniessen transferred this issue from nodejs/node-core-utils Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants