Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the shared travis config with auto-updates for node releases #85

Open
dominykas opened this issue Sep 1, 2020 · 2 comments
Open

Comments

@dominykas
Copy link
Member

tl;dr: I'd like to open a PR to replace the node_js section in the .travis.yml with an imported https://github.com/nodejs/ci-config-travis/blob/master/lts/gte-8.yml

Background: Package Maintenance WG has built a repository of shared Travis CI imports. The imports will be automatically updated as new Node.js versions get released.

Judging by what's inside the current .travis.yml here, and the missing engines in the package.json, I suspect that the lts upgrade policy is the right fit (it adds new versions as soon as they are released, never removes LTS versions, removes non-LTS versions when they reach EOL).

Is that OK?

@richardlau
Copy link
Member

I have no objections. I'd also be open to moving from Travis over to GitHub Actions like we have done for several other repositories in the nodejs org.

dominykas added a commit to dominykas/core-validate-commit that referenced this issue Sep 22, 2020
@dominykas
Copy link
Member Author

Opened #86 - as for GH actions - keep an eye out for https://github.com/nodejs/ci-config-github-actions (once we get that figured out...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants