Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warning when building example #122

Open
calvinmetcalf opened this issue Dec 10, 2019 · 1 comment
Open

warning when building example #122

calvinmetcalf opened this issue Dec 10, 2019 · 1 comment

Comments

@calvinmetcalf
Copy link

when building example 6 with nan I get

  CXX(target) Release/obj.target/addon/myobject.o
../myobject.cc:24:3: warning: ignoring return value of function declared with 'warn_unused_result' attribute [-Wunused-result]
  exports->Set(context,
  ^~~~~~~~~~~~ ~~~~~~~~
1 warning generated.
@helio-frota
Copy link
Contributor

helio-frota commented Nov 20, 2020

hi @calvinmetcalf thanks for report this. but I can't see this warning anymore (tested with node v12.19.1).

make: Entering directory '/home/hf/code/napi/node-addon-examples/6_object_wrap/node-addon-api/build'
  CXX(target) Release/obj.target/addon/addon.o
  CXX(target) Release/obj.target/addon/myobject.o
  SOLINK_MODULE(target) Release/obj.target/addon.node
  COPY Release/addon.node
make: Leaving directory '/home/hf/code/napi/node-addon-examples/6_object_wrap/node-addon-api/build'
audited 2 packages in 3.122s
found 0 vulnerabilities
$ node --version
v12.19.1

Should this issue be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants