Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple classes (wrapped objects) #180

Open
johnsauer99 opened this issue Apr 1, 2021 · 4 comments
Open

Multiple classes (wrapped objects) #180

johnsauer99 opened this issue Apr 1, 2021 · 4 comments

Comments

@johnsauer99
Copy link

My problem is multiple classes (objects) exported via my Init() functions.
I have two classes that I want to use in my javascript but the 'constructor' seems to be overwritten with whoever gets Init()'d i.e.:

// This code is present in both classes Init() method:
Napi::FunctionReference* constructor = new Napi::FunctionReference();
*constructor = Napi::Persistent(func);
env.SetInstanceData(constructor);
exports.Set("Dataset", func);

Question: Is it possible to export have more than one class object??

@mhdawson
Copy link
Member

I'm not quite sure what you mean by "class" in this context. There should only be one Napi::Addon instance for a given addon.

You can create multiple Napi::Object wrap instances.

@ikokostya
Copy link

Related issue #171

@ikokostya
Copy link

ikokostya commented May 2, 2021

@mhdawson Many examples in this repository repeat the following code snippet:

Napi::FunctionReference* constructor = new Napi::FunctionReference();
*constructor = Napi::Persistent(func);
env.SetInstanceData(constructor);

So only one data item can be associated with the current instance of the addon. In our case only one constructor. This works only for examples which contain single object wrap. Please see #171 for more details.

@mhdawson
Copy link
Member

mhdawson commented May 3, 2021

You are correct that only one data item can be associated with the current instance. Y

You can make what you set through env.SetIntsanceData a struct so that it can hold multiple C level pointers. Or possibly a linked list. If you make it a linked list then you could use GetInstanceData to get the current value set. If it is Null create the initial entry and set it, if it is not null then add to the linked list. At shutdown you'd then need to walk the list and do the right thing for each entry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants