Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate efficiency of alternative ACIR-gen for applying predicate to array_get #4972

Open
TomAFrench opened this issue May 3, 2024 · 0 comments

Comments

@TomAFrench
Copy link
Member

TomAFrench commented May 3, 2024

It would be interesting to compare this against the solution of adding an index offset instead of reading 0 to ensure that we read the correct typed value from the array. This keeps the final value a single witness rather than a quadratic expression so should result in better codegen in later opcodes.

Originally posted by @TomAFrench in #4971 (comment)

We're making every conditional read from an array into a quadratic expression in #4971. This may be resulting in worse-than-necessary acir gen later on as we use these results so it would be useful to compare the alternative.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant