fix: Add more thorough check for whether a type is valid when passing it from constrained code to unconstrained code #5009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfecher
commented
May 9, 2024
|
I'm not familiar enough with the debugger to know why it seems to be passing mutable references from constrained -> unconstrained or if it needs to do so or not. So I'm putting this PR on hold for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves #5008
Summary*
Thank you to @nventuro for the minimal example and @TomAFrench for looking into this. As a result it was a quick fix.
Additional Context
All type system fixes must currently be duplicated in the elaborator so I've included this there as well.
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.