Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does it make sense to merge this with youtube-video-js somehow? #10

Open
TehShrike opened this issue Dec 20, 2018 · 2 comments
Open

Does it make sense to merge this with youtube-video-js somehow? #10

TehShrike opened this issue Dec 20, 2018 · 2 comments

Comments

@TehShrike
Copy link
Member

@mkay581 is interested in merging https://github.com/mkay581/youtube-video-js with this repo/project somehow.

Does this make sense? What would the entry point to the web component be? I don't feel comfortable pointing the main entry point to something completely different.

@markcellus
Copy link

markcellus commented Dec 20, 2018

Yeah I'd love to find some way to collaborate on this. It looks like this API is very very similar and we both have people who want both of our packages. I'm just an advocate for less fragmentation in the open-source community so I'd like to get your ideas on it.

@TehShrike the main entry point would be to the web component class which would be exported, like I'm doing here.

@TehShrike
Copy link
Member Author

What I meant is: I'm not willing to change the main entry point of the youtube-video package to something that isn't a function like the one currently exported.

If the youtube-video package also contained a web component, it would have to be exposed some other way. e.g. the readme could say "if you want this web component, you should import { YoutubeVideoElement } from youtube-video/web-component.js"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants