Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add this to the scripts. #17

Open
hemanth opened this issue Aug 7, 2015 · 6 comments
Open

Add this to the scripts. #17

hemanth opened this issue Aug 7, 2015 · 6 comments

Comments

@hemanth
Copy link
Member

hemanth commented Aug 7, 2015

"scripts": {
  "test": "mocha --require babel/register",
  "tdd": "npm test -- --watch",
  "coverage": "isparta cover _mocha index.js -- --require babel/register",
  "precoveralls": "npm run coverage",
  "coveralls": "coveralls < coverage/lcov.info",
  "transpile": "babel index.js > index.es5.js",
  "prepublish": "npm run transpile",
  "postpublish": "rm *.es5.js && git push --follow-tags"
}

Thanks to @iamstarkov

@iamstarkov
Copy link

no chance for &&, use npm-run-all:

  "scripts": {
    "coverage": "isparta cover _mocha index.js -- --require babel/register",
    "precoveralls": "npm run coverage",
    "coveralls": "coveralls < coverage/lcov.info",
    "test": "mocha --require babel/register",
    "tdd": "npm test -- --watch",
    "transpile": "babel index.js > index.es5.js",
    "prepublish": "npm run transpile",
    "clean": "trash index.es5.js",
    "push": "git push --follow-tags",
    "postpublish": "npm-run-all clean push"
  },

@stoeffel
Copy link
Contributor

stoeffel commented Aug 7, 2015

What's the problem with &&? Should we change this in the other scripts too? I like the scripts, but I'm not sure if we should add this really specific scripts like f.e. isparta cover _mocha index.js -- --require babel/register...

@iamstarkov
Copy link

&& is not working on windows. you can use pre/post scripts or npm-run-all tool

@stoeffel
Copy link
Contributor

stoeffel commented Aug 7, 2015

Okay. Then I think we should change all the script to use npm-run-all.
refs tomek-he-him/ideas#1

@stoeffel
Copy link
Contributor

stoeffel commented Aug 8, 2015

Had a second look at the scripts. This are the scripts I would add. @hemanth which do you want to add?

  • coverage: to specific
  • precoveralls: SGTM
  • coveralls: SGTM
  • test: to specific
  • tdd: same as develop
  • transpile: to specific
  • prepublish: to specific
  • clean: to specific
  • push: SGTM
  • postpublish: to specific

@hemanth
Copy link
Member Author

hemanth commented Aug 8, 2015

All the SGTM, SGTM 🎐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants