Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make S3 endpoint configurable #262

Open
tongmingleee opened this issue May 14, 2019 · 5 comments
Open

Make S3 endpoint configurable #262

tongmingleee opened this issue May 14, 2019 · 5 comments

Comments

@tongmingleee
Copy link

tongmingleee commented May 14, 2019

We would like to use commuter as a way to share notebooks on S3, but we are not using AWS S3 and there is no way to configure S3 endpoint.
Can you make S3 endpoint configurable as environment variables?
The change is easy and straightforward, would like to contribute to it.

@brunowego
Copy link

I have a similar issue, my infrastructure have MinIO, currently we have a mount point with NFS to the data folder.

@captainsafia
Copy link
Member

Hello @tongminglee! Thanks for opening this issue.

Are you looking for S3 configuration options beyond those that exist currently? If so, happy to take a look at an example implementation you can provide in a PR.

@withsmilo
Copy link

@tongmingleee @brunowego @captainsafia
I implemented it!

@dazzag24
Copy link

dazzag24 commented Sep 2, 2019

Hi, Any plans to support other storage backends such as Azure blob storage?

Thanks
Darren

@captainsafia
Copy link
Member

@dazzag24 No implementation plans at the moment but PRs adding support for other storage backends are welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants