Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cells hidden with Papermill are not hidden #273

Open
derek-pyne opened this issue Sep 18, 2019 · 2 comments
Open

Cells hidden with Papermill are not hidden #273

derek-pyne opened this issue Sep 18, 2019 · 2 comments

Comments

@derek-pyne
Copy link

I am using Papermill to render notebooks in which I would like to have the input hidden. Papermill has a report_mode which I am using to do this.

This seems to add the source_hidden metadata to each cell as below:

{
    "jupyter": {
        "source_hidden": true
    },
    "papermill": {
        "duration": 0.014058,
        "end_time": "2019-09-18T19:54:49.695565",
        "exception": false,
        "start_time": "2019-09-18T19:54:49.681507",
        "status": "completed"
    },
    "tags": []
}

When I open these notebooks in JupyterLab the cells are correctly hidden but when I view them in Commuter no cells are hidden. Should this work or is there another supported way to hide input?

@captainsafia
Copy link
Member

commuter is currently using the @nteract/notebook-preview component. Tangent: this component has been deprecated and we need upgrade to use the components out of @nteract/presentational-components.

The component currently only interprets input_hidden and inputHidden as metadata for hiding the source. nbformat doesn't have a this as part of the spec yet, AFAIK.

IMO, report_mode should set the inputHidden property in addition to source_hidden. Thoughts on this, @MSeal?

@MSeal
Copy link
Member

MSeal commented Nov 18, 2019

@captainsafia Yes we should probably change it. I would prefer we used camel cased fields input_hidden to match the casing for all the other standard fields, but I think a PR would be a good idea to papermill for that change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants