-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replay Buffer Options Are "Locked" When 'Rate Control' Is Set To Lossless #10595
Comments
Hi @Knewest Can you please provide a video recording of the issue |
Hi, I seem to have miscommunicated and said you can't enable/disable replay buffers, but you can. Issue of it being essentially "locked" still persists, and other 'Rate Control' settings appear to have missing settings too, but this seems more intentional than "locked" settings which can be modified (and do save) using a different 'Rate Control' setting. Requested video: Additional video of me having to switch 'Rate Control' setting to change the replay buffer setting for lossless: |
I'm still confused if this is a bug report or a feature request. Are you saying that the replay buffer is working in lossless, but you just can't change the settings? Replay buffer should be disabled entirely when lossless output modes are selected, so this seems like an oversight. |
This is a bug report. I believe that the user not being able to modify the two fields that control max file size and buffer length is a bug, as changing them for compressed options does change it for the lossless setting too.
Yes.
But why? It works perfectly fine, and users should be allowed to choose if they want lossless encoding for their replay buffer or not. |
Because the amount of data that a lossless replay buffer would be shoving through RAM is too prone to failure, too restrictive (probably only going to manage a few seconds of footage), and causes an immense support burden on us. I've tested setting lossless modes, and the replay buffer is properly disabled in simple output mode, so there is likely an oversight that didn't disable similarly in advanced mode. We'll discuss internally if this is something we want to realistically support. |
That does make sense, but for those who know what they are doing, this is extremely useful. Perhaps locking it behind some sort of toggle to reduce the number of reports? I personally have the lossless replay buffer last 10 minutes, or 5GB. It would be great if this was heavily considered. Otherwise, I may have to be on this version forever due to future updates locking it. |
Hi @Knewest Thank you for providing the video recording of the issue Unfortunately I don't have the NVIDIA NVENC HEVC option in the Video encoder due to which I'm unable to use the Lossless Rate Control option If someone else takes look into your issue/request, it would be a lot of help to you |
Operating System Info
Windows 11
Other OS
No response
OBS Studio Version
30.1.2
OBS Studio Version (Other)
No response
OBS Studio Log URL
https://obsproject.com/logs/kOWn0IxmE7ed4Bq5
OBS Studio Crash Log URL
No response
Expected Behavior
If I enable lossless 'Rate Control', I should be able to freely modify the replay buffer accordingly without extra steps (such as temporarily disabling lossless 'Rate Control').
Current Behavior
Because of this issue, I have to set the 'Rate Control' setting to VBR, CQP, or CBR to be able to freely modify, the 'Replay Buffer' feature, which is extremely inconvenient. Otherwise, I am able to use the set settings and use the replay buffer losslessly without issues. You can view the OBS Studio Log URL to see my settings for the replay buffer.
Steps to Reproduce
Anything else we should know?
Please don't actually disable the replay buffer for lossless rate controls, rather it should be allowed to be used losslessly. I have been actively using lossless rate control for a while now, and it is extremely useful for me, as I manually compress the replay to my own desire and quality needs. I greatly appreciate high quality.
The text was updated successfully, but these errors were encountered: