We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hey there,
My name is Maciej Mensfeld and I run security & quality assessment for OSS libraries using WhiteSource Diffend.io.
While reviewing the changes for this lib, I noticed, that the vendor directory is being included.
Is this needed? Usually, it's added by mistake and causes:
a) confusion b) problems when tracking changes c) extensive library size
ref: https://my.diffend.io/gems/rfix/2.0.4/3.0.0/page/4#d2h-911935
It seems (at least in 3.0.0 that out of all vendor packages at least dry-cli and strings-ansi are declared as dependencies in the gemspec.
3.0.0
dry-cli
strings-ansi
If the presence of vendor data is valid I would love the reasoning. Thanks!
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Hey there,
My name is Maciej Mensfeld and I run security & quality assessment for OSS libraries using WhiteSource Diffend.io.
While reviewing the changes for this lib, I noticed, that the vendor directory is being included.
Is this needed? Usually, it's added by mistake and causes:
a) confusion
b) problems when tracking changes
c) extensive library size
ref: https://my.diffend.io/gems/rfix/2.0.4/3.0.0/page/4#d2h-911935
It seems (at least in
3.0.0
that out of all vendor packages at leastdry-cli
andstrings-ansi
are declared as dependencies in the gemspec.If the presence of vendor data is valid I would love the reasoning. Thanks!
The text was updated successfully, but these errors were encountered: