Skip to content
This repository has been archived by the owner on Apr 16, 2024. It is now read-only.

Provide more meaningful message when DOI pattern not matched #106

Open
vsoch opened this issue Jul 20, 2021 · 3 comments
Open

Provide more meaningful message when DOI pattern not matched #106

vsoch opened this issue Jul 20, 2021 · 3 comments

Comments

@vsoch
Copy link

vsoch commented Jul 20, 2021

We just ran into a whedon mysterious error here:

openjournals/joss-reviews#3311

And actually the issue was that here there was a DOI that was missing the first half of the pattern, so it didn't match anything, returned nil, and whedon choked. I'm wondering if we can do some third check there for nil again, and if it's nil, print a meaningful error message? I really like Ruby (and don't get to use it super often) so if you'd like to give me guidance on how this could be best implemented I'd really enjoy doing it!

I also was trying to reproduce locally and I got as far as to run bundle exec whedon compile 3311 with my repo in tmp/3311 but then a style file was missing. I think it would be really useful to have a little more structure or guidance for how to run whedon locally (e.g., where is that style file?) so if future issues arise developers can more easily debug. Thank you!

@danielskatz
Copy link

let's make sure we have found the problem :)

@danielskatz
Copy link

ok, that was the problem - we had

DOI="journal.pone.0177459"

instead of

DOI="10.1371/journal.pone.0177459"

and the error message we got back was quite confusing (but kind of fun to debug)

@vsoch
Copy link
Author

vsoch commented Jul 20, 2021

Agree!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants