Skip to content
This repository has been archived by the owner on Jan 20, 2022. It is now read-only.

Improve floating toolbar behavior #197

Open
thenanyu opened this issue May 25, 2020 · 4 comments
Open

Improve floating toolbar behavior #197

thenanyu opened this issue May 25, 2020 · 4 comments
Labels
$$$ This issue is sponsored by Outline, optional payment is available – contact hello@getoutline.com enhancement New feature or request

Comments

@thenanyu
Copy link
Collaborator

thenanyu commented May 25, 2020 •
edited

This is a minor display quibble, but since the floating toolbar remains fixed at the top of a selection it should have its position based on the top line of the selection. I think what's happening is that it's recalculating based on the highlight length of the current cursor position.

Video here
@thenanyu thenanyu added the bug Something isn't working label May 25, 2020
@thenanyu thenanyu changed the title the floating toolbar humps around when selecting multiple lines of text the floating toolbar jumps around when selecting multiple lines of text May 25, 2020
@tommoor
Copy link
Member

tommoor commented May 25, 2020

Makes sense, measuring just the width of the top of the selection might be quite difficult though – an approach doesn't immediately come to mind for how to achieve that, especially considering it could be any type of node and not just a paragraph.

@tommoor tommoor added enhancement New feature or request and removed bug Something isn't working labels Jun 23, 2020
@tommoor
Copy link
Member

tommoor commented Jul 22, 2020 •
edited

Two improvements:

  • Don't show the toolbar until mouse up
  • Show the toolbar at the bottom of the selection if dragging from top -> bottom

@tommoor tommoor changed the title the floating toolbar jumps around when selecting multiple lines of text Improve floating toolbar behavior Jul 22, 2020
@tommoor tommoor added the $$$ This issue is sponsored by Outline, optional payment is available – contact hello@getoutline.com label Jul 22, 2020
tommoor added a commit that referenced this issue Aug 12, 2020
@tommoor
fix: Toolbar is only visible on mouse Dup
6653dc8 
Related #197
@rblalock
Copy link

Is there a reason the toolbar doesn't have a class name associated with it? Some way to target and style it separately?

@rblalock
Copy link

Just added a PR for the className. #283

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
$$$ This issue is sponsored by Outline, optional payment is available – contact hello@getoutline.com enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rblalock @tommoor @thenanyu