Skip to content
This repository has been archived by the owner on Jan 20, 2022. It is now read-only.

onChange called on init when view == null #611

Open
fedotxxl opened this issue Dec 25, 2021 · 1 comment
Open

onChange called on init when view == null #611

fedotxxl opened this issue Dec 25, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@fedotxxl
Copy link

  1. Create h1 opened, save
  2. Open, collapse h1, don't save
  3. Refresh

In this case, h1 state will be read from localStorage, differ from JSON persisted state and onChange callback triggered. The problem is that view is not ready and getting value will result to Cannot read properties of undefined (reading 'state')

Solution add this.view check?

  handleChange = () => {
    if (!this.props.onChange || !this.view) return;

    this.props.onChange(() => {
      return this.value();
    });
  };

@fedotxxl fedotxxl added the bug Something isn't working label Dec 25, 2021
@came
Copy link

came commented Dec 27, 2021

I am getting the same error occasionally. And yes, it looks like it has something to do with h1 getting collapsed.

BR, Carsten

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants