Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global styles injected on import #11

Open
hasparus opened this issue Jul 13, 2018 · 6 comments
Open

Global styles injected on import #11

hasparus opened this issue Jul 13, 2018 · 6 comments

Comments

@hasparus
Copy link

When you import a component you also get all the global styles (like text being Neucha, sans-serif).
That forces you to override styles like it's 2005.
Current solution imports css. Could we use CSSModules or styled-components instead?

@hasparus hasparus changed the title Global styles inject side effect on import Global styles injected on import Jul 13, 2018
@hasparus
Copy link
Author

I can prepare a PR if core maintainers agree.

@Banjerr
Copy link
Collaborator

Banjerr commented Jul 13, 2018 via email

@hasparus
Copy link
Author

Okay, so I'm adding this issue to my todo list. :)

@hasparus
Copy link
Author

Okay, i finally got into it. I have really important question, @Banjerr. What do you think about TypeScript? ^.^

@Banjerr
Copy link
Collaborator

Banjerr commented Aug 29, 2018

@hasparus i haven't used TypeScript a lot, but i'm certainly open to it if you think it would benefit the project 🙌

@hasparus
Copy link
Author

hasparus commented Sep 2, 2018

Since the issue breaks backwards compatibility, because styles are no longer global, I'm going to use this occasion to expand examples a little bit.
screen shot 2018-09-02 at 14 26 20-fullpage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants