Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freeing the UiDrawPath #121

Open
mimecorg opened this issue Jul 20, 2018 · 2 comments
Open

Freeing the UiDrawPath #121

mimecorg opened this issue Jul 20, 2018 · 2 comments

Comments

@mimecorg
Copy link

Unlike most other drawing related classes, UiDrawPath has an explicit freePath() method, and the path handle is not freed automatically in the destructor. So when the UiDrawPath is destroyed by the garbage collector, the path handle is never freed. Is this intentional?

@mischnic
Copy link
Collaborator

mischnic commented Jul 20, 2018

Is this intentional?

I don't remember that it was. The other area classes were changed in this commit: 3f99317

@parro-it I commited the change to https://github.com/parro-it/libui-node/commits/path-destructor.
Should we keep the function as a noop for compatibility? It's missing in libui-napi.

@parro-it
Copy link
Owner

I also don't remember it to be intentionally done...

@parro-it I commited the change to https://github.com/parro-it/libui-node/commits/path-destructor.
Should we keep the function as a noop for compatibility? It's missing in libui-napi.

I remember we already discuss the matter on libui-napi repo, and we decided to remove them...
so I suppose we can remove them here too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants