-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG]: 5.3.1 to 5.4.0: Phalcon\Mvc\Router\Exception: A dependency injection container is required to access the 'request' service #16460
Comments
@fichtner I did a diff between 5.3.1 and 5.4.0 and did not see any changes in the router or anything else that might be indicative of why you see this error. In the Router code the check is this:
so Phalcon sees that the container is If you want ping me in discord to try and diagnose this further, since I will need help to set opnsense up on my local to debug. |
Thanks for taking a closer look. Let me see if I can reproduce this with a clean build on Monday and let you have a simple script that triggers this too before proceeding. Cheers, |
I had some spare time: clean compile and issue still exists. Also glanced over the diff on your end but came up empty as well. Cheers, |
Still the case on 5.6.1. Can we pick this back up? I reckon it might be more of an application issue, but still sort of a regression that I can't wrap my head around. Cheers, |
I followed similar reports and ended up "fixing" it with opnsense/core@5f855524e -- for me it's ok to close but I'd like someone to look if that was intended... :) |
See also: phalcon/cphalcon#16460 (cherry picked from commit 5f85552)
I run into this as well after an OPNSense update 2 days ago. |
@zoechi wrong repo and no actual information attached to be of any help |
@fichtner it was the only search result. Sorry for not providing more information. |
Was probably in an intermittent update state with newer Phalcon package and older core package. All patched to 24.1.2 should get rid of the error for good indeed. 😊 |
Describe the bug
Exception after updating from 5.3.1 to 5.4.0:
To Reproduce
Our code in question has been working through multiple Phalcon major versions here. Code reference:
https://github.com/opnsense/core/blob/d560e84934d5f00a3dfa10245fd3853a3f7e6ab3/src/opnsense/mvc/app/config/services_api.php#L90L94
Expected behavior
Act like 5.3.x ideally. Could be something we handled wrong here forever though.
Screenshots
N/A
Details
5.4.0
Additional context
N/A
The text was updated successfully, but these errors were encountered: