Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unset values #63

Open
piranna opened this issue Jul 1, 2023 · 2 comments
Open

unset values #63

piranna opened this issue Jul 1, 2023 · 2 comments
Assignees
@phanect
Labels
bug Something isn't working

Comments

@piranna
Copy link

piranna commented Jul 1, 2023

According to the spec, if any value is the unset string, it should disable the rule and accept editor defaults, but I see no references in the source code. We should check the values before hand and disable the rules if possible, or at least set them to undefined so eslint defaults are being used instead. Not sure if this can be done in a preprocessing step, or would need to be done in a rule-by-rule basis, specially when a rule makes use of several editorconfig definitions.
@piranna
Copy link
Author

piranna commented Jul 2, 2023

editorconfig/editorconfig-core-js#123

@phanect phanect self-assigned this Jul 2, 2023
@phanect phanect added the bug Something isn't working label Jul 2, 2023
@piranna
Copy link
Author

piranna commented Jul 2, 2023

editorconfig/editorconfig-core-js#123 (comment)

Published version 2.0.0 of editorconfig-core-js just to provide upstream the fix needed by this, so we don't need to do it ourselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phanect phanect

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@phanect @piranna