feat: add option quietResLogger to supress response data from res.log entries
#256
Conversation
|
Done @mcollina This is marked as a draft because I'm not confident on the changes I've made yet since the tests aren't running :/ Actually, I believe that there is something wrong here. I'm still trying to implement this feature. |
micalevisk
force-pushed
the
feat/issue-235
branch
from
ae7df9e
to
58979fa
Compare
micalevisk
force-pushed
the
feat/issue-235
branch
from
58979fa
to
96bd72a
Compare
|
What errors are you getting? |
| let fullReqLogger = reqLog.child({ [reqKey]: req }) | ||
|
|
||
| const resLog = quietResLogger ? logger.child({ [requestIdKey]: req.id }) : logger | ||
| let fullResLogger = resLog.child({ [resKey]: res }) |
There was a problem hiding this comment.
What errors are you getting?
@mcollina a bunch of tests stop passing after adding this line
There was a problem hiding this comment.
could we not do this?
const log = quietReqLogger || quietResLogger ? logger.child({ [requestIdKey]: req.id }) : logger
and leave the rest of the code as is?
There was a problem hiding this comment.
hm, I just did it but the tests are still not passing
There was a problem hiding this comment.
I actually really want this feature, I'll pull tomorrow and use some work time on it
|
actually the misunderstood the ticket, I wanted a way to disable the request complete log. have a PR here #259 |
closes #235
I didn't succeeded on making the
npm trunning with no errors, even in the fresh new cloned repo 馃