-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
redesign header #281
Comments
I liked the lines. On Jun 23, 2013, at 6:29 PM, Zach Holman notifications@github.com wrote:
|
looks great.. |
Looks good. Def work in the concept of the channel you're looking at as that's the future. V3-channels should be mergable this week.
|
Cool, but we should plainly show the current channel you're in. Have you used the channel stuff yet? There's the concept of having a currently picked channel while your'e browsing/searching, so when you queue, it uses that channel. It should be showing at all times to surface that context. |
The other thing is, channels are going to need a couple new views One for History, showing the feed of songs that have been previously played on them. This is pretty crucial for going back and seeing what you heard recently, as well as providing another outlet for browsing stuff. Another for Popular. This should show the most popular tracks that have been manually queued on the channel. You might want to keep this in mind when designing the header. |
Yep I've used it; I'm jamming Rush via Floor 2 now; however, I've not found the need to look back to what channel I'm on. Apparently I'm the set it and get it out of my way type user. My goal has been to clean out the extra elements, we could add it into the dropdown: I don't think the history and popular views belong in the global navigation. Your absolutely correct we'll need them but I think we're going to need to develop a sub section for the current channel. I'll go back to work on that when I need another break from the current task. |
You're missing the point. Once you pick your channel, thats the channel that will then be used when you queue something inside the web views. Because of this, it needs to be surfaced at all times. Otherwise if you're looking at the song list for Nirvana Nevermind, and you want to queue a couple songs from it, you have no idea what channel they will actually be queued to. |
No, I understand. I'm not saying its a bad idea to have it there; I'm saying I understand that when I'm listening to HQ Floor 2 - I already assume that anything I add will be played on that channel. |
It has absolutely NOTHING to do with what you're tuned to/listening to via a Play client. It has to do with what you picked on the first page of Play. |
heh, well then I think the experience is broken. Is that a technical decision or something we thought was the best? |
@mattgraham i disagree. The site shoudln't be dependent on your actions in a client app. I mean, you can stream in itunes or any other shoutcast capable app via the stream and theres no concept of a channel, its just tuning the stream. What if you're in the office and the stream is playing over a speaker that is tuned itself to a certain channel? What channel is picked "for you" when you hit the site? You don't even have a client opened on your own computer. Clients and the site should be 100% independent. Your client can be tuned to a channel to play. But you should be able to see any channel and queue to any channel you want on the site. They're 100% independent. |
I moved the streaming stuff to the top because the absolutely-positioned stream on the bottom was super janky. Between that and the profile it kind of looks gross:
We should move the stream and profile elsewhere... they needed be in the header necessarily.
help me @mattgraham
The text was updated successfully, but these errors were encountered: