Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ineffective org membership verification #361

Open
paxan opened this issue Nov 20, 2013 · 0 comments
Open

Ineffective org membership verification #361

paxan opened this issue Nov 20, 2013 · 0 comments

Comments

@paxan
Copy link

paxan commented Nov 20, 2013

I've noticed that org members that were not publicizing their membership were S.O.L.

They get this error:
You don't seem to be in correct GitHub Organization

The problem goes away once they hit "Publicize membership" button for themselves on the org members page. So that's the good news: we have the workaround.

I believe that a more appropriate way to check membership is
GET /orgs/:org/members/:user as described in Organization Members API. Then you'd display "the day the music stopped..." error if response status is other than 204.

I am running Play off v3 branch, FYI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant