Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ABI agnostic packages #147

Open
piranna opened this issue Dec 11, 2016 · 5 comments
Open

ABI agnostic packages #147

piranna opened this issue Dec 11, 2016 · 5 comments
Labels
enhancement New feature or request

Comments

@piranna
Copy link
Member

piranna commented Dec 11, 2016

How is it possible to define that a package is ABI agnostic both for publishing and download? Maybe setting the ABI to *? If it's not currently possible, could it be easy to add this functionality? For download it could check if there's one for the current ABI and if not check for the *, what do you think?

@juliangruber
Copy link
Collaborator

what are abi agnostic packages, can you link to one?

@piranna
Copy link
Member Author

piranna commented Dec 12, 2016

I'm using prebuild to publish npm packages with the cross-compiler of NodeOS and other external tools like genextfs, and being standalone binaries it doesn't make sense the concept of Node.js ABI at all, but instead it makes sense to have published precompiled binaries so the users don't need to compile themselves.

@vweevers
Copy link
Member

vweevers commented Mar 3, 2019

N-API is the preferred way to achieve this. I don't think it's feasible or desirable to have prebuild support both N-API and custom ways of abi agnostic packages. You might be able to "mask" your custom binary as an N-API binary though, and trick prebuild(-install) into loading that.

@vweevers vweevers closed this as completed Mar 3, 2019
@piranna
Copy link
Member Author

piranna commented Mar 3, 2019

N-API doesn't apply here because I'm not creating native Node.js modules but instead I'm distributing executables not directly related to Node.js at all, so ABI version is useless here.

@vweevers
Copy link
Member

vweevers commented Mar 3, 2019

Sorry, I misunderstood.

@vweevers vweevers reopened this Mar 3, 2019
@vweevers vweevers added the enhancement New feature or request label Mar 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants