Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prebuild v13 accidentally removed support for node-ninja and nw-gyp, possible next steps #323

Open
lovell opened this issue Feb 16, 2024 · 0 comments

Comments

@lovell
Copy link
Member

lovell commented Feb 16, 2024

In moving to take advantage of the Promise-based API provided by node-gyp v10 in #316, we inadvertently broke the use of alternative "backends" (i.e. forks of node-gyp), namely node-ninja and nw-gyp, which still rely on callbacks.

Some possible options (there will be others):

  1. Include an implicit mapping for each "backend" to determine if we need to "promisify" them.
  2. Add a new, explicit --backend-uses-callbacks option that does what it says on the tin.
  3. Move node-ninja and nw-gyp to optional peer dependencies and assume they will always use callbacks.

Thoughts/alternatives welcome, especially if you help maintain an open source package that depends on the node-ninja or nw-gyp forks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant