You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In moving to take advantage of the Promise-based API provided by node-gyp v10 in #316, we inadvertently broke the use of alternative "backends" (i.e. forks of node-gyp), namely node-ninja and nw-gyp, which still rely on callbacks.
Some possible options (there will be others):
Include an implicit mapping for each "backend" to determine if we need to "promisify" them.
Add a new, explicit --backend-uses-callbacks option that does what it says on the tin.
Move node-ninja and nw-gyp to optional peer dependencies and assume they will always use callbacks.
Thoughts/alternatives welcome, especially if you help maintain an open source package that depends on the node-ninja or nw-gyp forks.
The text was updated successfully, but these errors were encountered:
In moving to take advantage of the Promise-based API provided by
node-gyp
v10 in #316, we inadvertently broke the use of alternative "backends" (i.e. forks ofnode-gyp
), namelynode-ninja
andnw-gyp
, which still rely on callbacks.Some possible options (there will be others):
--backend-uses-callbacks
option that does what it says on the tin.node-ninja
andnw-gyp
to optional peer dependencies and assume they will always use callbacks.Thoughts/alternatives welcome, especially if you help maintain an open source package that depends on the
node-ninja
ornw-gyp
forks.The text was updated successfully, but these errors were encountered: