Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent doctype case formatting #3358

Open
MrDanielHarka opened this issue Mar 31, 2024 · 2 comments
Open

Inconsistent doctype case formatting #3358

MrDanielHarka opened this issue Mar 31, 2024 · 2 comments

Comments

@MrDanielHarka
Copy link

No, I don't have a preference if the doctype is lowercase or uppercase, like the below mentions:

I really don't care. But please make it at least consistent. Now I get changes in git just because Prettier formats it inconsistently.

Prettier v10.4.0

Case 1: Prettier auto-formatting in VSCode with extension.

Input:

<!doctype html>

Output:

<!DOCTYPE html>

Case 2: Prettier CLI formatting using bunx prettier index.html

Input:

<!DOCTYPE html>

Output:

<!doctype html>

Expected behavior:
The two tools should have the same case formatting for the doctype tag, whichever it is.

@studioswong
Copy link

Seconding this issue as I had just experienced the same while formatting my code via the CLI, and was confused about the discrepancy - what is the prettier's team's recommendation on this? ( I noticed multiple discussions on the debate between uppercase and lowercase, including this one - while my understanding is that the prettier team recommends lowercase and enforces it by default back in 2019, I wonder is this still the case now?)

@eligrey
Copy link

eligrey commented May 9, 2024

Lowercase is invalid XML. This shouldn't be difficult to resolve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants