Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Primeng Table: Clear the filters which are not applied when filter menu closed by clicking outside the menu #15557

Closed
gopikrishna-manifest opened this issue May 14, 2024 · 0 comments · Fixed by #15594
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@gopikrishna-manifest
Copy link

Describe the bug

Hi Team,
We are using Primeng Tables filter option. We need to clear the filters which are selected but not applied when we close filter menu by clicking outside of the menu.
Steps to reproduce:

  1. Open the Primeng filter menu example. https://primeng.org/table#filter-menu

  2. Click on Filter icon beside Name / Country column and open the filter menu.

  3. Enter some text in the text box
    Screenshot_4

  4. Click out side the filter menu. Now the filter menu will close without applying the filter

  5. But you can see the filter icon turns to blue indicating that some filter applied to that column
    image

  6. Again open the Filter menu for the same column

  7. You can see the same text in the filter.
    image

Expected Result

  1. It should clear the filters which are not applied
  2. The Filter icon shouldn't turn to blue

Actual Result

  1. It is not clearing the filters which are not applied when we click outside the menu
  2. The icon turning to blue even no filter applied to that column.

PrimeNG Discussion Link https://github.com/orgs/primefaces/discussions/1718

Environment

Angular And Windows

Reproducer

No response

Angular version

17.3.1

PrimeNG version

17.16.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.13.0

Browser(s)

Chrome

Steps to reproduce the behavior

No response

Expected behavior

No response

@gopikrishna-manifest gopikrishna-manifest added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label May 14, 2024
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels May 30, 2024
@cetincakiroglu cetincakiroglu added this to the 17.18.0 milestone May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants