You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
npm i purescript installs PureScript by running npm-installer's install command via a post-install script. The npm-installer codebase is undesirable for a number of reasons:
it's written in JavaScript and thus doesn't utilize type safety. Moreover, it's hard to read in general.
it uses old NPM dependencies which produces a number of warnings and other output.
At one time, when this package was originally outside of the core team's control, malicious code was added to it before Harry dealt with that.
While working on the port, I noticed that the binaries downloaded from GitHub are not checked for their integrity via the SHA files.
By rewriting this in PureScript, we gain:
type-safety
readability
updated NPM dependencies
integrity checks
a clean slate
Proposal
I propose a few people from the core team review the work I've done, make edits as needed, and then update our npm-package/package.json to use purs-installer as the post-install script.
Examples
At least one or two examples of the proposal being used.
The text was updated successfully, but these errors were encountered:
I think there's two potential issues with my current proposal:
purs-installer has no CI checks to verify that ARM builds work, mainly due to GH Actions not having such CI runners available (though they're supposed to enter beta in Jan 2024)
purs-installer does not expose a command for building from source, nor have CI checks that verify such installs work. I didn't add that mainly because this feature doesn't appear to work on npm-installer anyway.
Summary
Replace npm-installer with purs-installer
Motivation
npm i purescript
installs PureScript by runningnpm-installer
'sinstall
command via a post-install script. Thenpm-installer
codebase is undesirable for a number of reasons:By rewriting this in PureScript, we gain:
Proposal
I propose a few people from the core team review the work I've done, make edits as needed, and then update our
npm-package/package.json
to usepurs-installer
as the post-install script.Examples
At least one or two examples of the proposal being used.
The text was updated successfully, but these errors were encountered: