Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"use openssl@<...> from homebrew" is displayed even if OpenSSL to use has been specified explicitly #2852

Open
Fares-Abubaker opened this issue Nov 26, 2023 · 6 comments

Comments

@Fares-Abubaker
Copy link

I am trying to install Python and build it using OpenSSL 3.1, but it always using OpenSSL 1.1
I tried many ways to ensure that I configure OpenSSL 3.1 but nothing changed

I am using Mac M1 with Homebrew
latest version of pyenv and python-build

❯ CONFIGURE_OPTS="--with-openssl=$(brew --prefix openssl@3.1) --with-openssl-dir=$(brew --prefix openssl@3.1) --with-openssl-include=$(brew --prefix openssl@3.1)/include --with-openssl-lib=$(brew --prefix openssl@3.1)/lib" pyenv install 3.11.6

python-build: use openssl@1.1 from homebrew
python-build: use readline from homebrew
...

Is there an issue or what is the problem ?!

@Fares-Abubaker Fares-Abubaker changed the title build python using OpenSSL 3.1 Build python using OpenSSL 3.1 Nov 26, 2023
@native-api
Copy link
Member

Confirmed, the use_homebrew_openssl() function does not detect if OpenSSL-related arguments have been passed.

As a workaround, set envvar PYTHON_BUILD_HOMEBREW_OPENSSL_FORMULA=<Homebrew formula name> to manually specify the Homebrew formula to pick.

@native-api
Copy link
Member

Though, user-supplied Configure options are put after Pyenv-supplied ones, so your command should actually be building against OpenSSL 3.1 despite that message.

@Fares-Abubaker
Copy link
Author

Great news @native-api thanks

but this shouldn't be fixed ?

@native-api
Copy link
Member

Yes, it should.

@Fares-Abubaker
Copy link
Author

in fact this worked now:

❯ PYTHON_BUILD_HOMEBREW_OPENSSL_FORMULA=openssl@3.1 pyenv install 3.10.13 

python-build: use openssl@3.1 from homebrew
python-build: use readline from homebrew
...

@Fares-Abubaker
Copy link
Author

i suggest to add this to the readme

@native-api native-api changed the title Build python using OpenSSL 3.1 "use openssl@<...> from homebrew" is displayed even if OpenSSL to use has been specified explicitly Nov 26, 2023
@native-api native-api reopened this Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants