Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support encoded RLE format in for COCO segmentations #8387

Merged
merged 3 commits into from
Jun 4, 2024
Merged

Support encoded RLE format in for COCO segmentations #8387

merged 3 commits into from
Jun 4, 2024

Conversation

NicolasHug
Copy link
Member

@NicolasHug NicolasHug commented Apr 19, 2024 •
edited

Closes #8351

This lets our COCO wrapper support segmentations that are already in "encoded RLE" format.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Apr 19, 2024 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8387

Note: Links to docs will display an error until the docs builds have been completed.

❌ 11 New Failures, 8 Unrelated Failures

As of commit 2f7c1a5 with merge base 26af015 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@NicolasHug NicolasHug requested a review from pmeier April 19, 2024 15:53
NicolasHug
NicolasHug commented Apr 19, 2024
View reviewed changes
test/test_datasets.py
@@ -832,11 +846,27 @@ def test_slice_error(self):
with pytest.raises(ValueError, match="Index must be of type integer"):
dataset[:2]

def test_segmentation_kind(self):
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really not a fan of that test's logic, but I don't know how to better test that. @pmeier LMK if there are better options?

@NicolasHug NicolasHug mentioned this pull request Apr 19, 2024
Closed
@NicolasHug NicolasHug merged commit f7d9e75 into pytorch:main Jun 4, 2024
42 of 63 checks passed
@NicolasHug NicolasHug deleted the aelfjnalefjnaef branch June 4, 2024 12:01
facebook-github-bot pushed a commit that referenced this pull request Jun 7, 2024
@NicolasHug @facebook-github-bot
[fbsync] Support encoded RLE format in for COCO segmentations (#8387)
27dc11c 
Reviewed By: vmoens

Differential Revision: D58283856

fbshipit-source-id: 98805162e3209173811108468037ea490d123082
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmeier pmeier Awaiting requested review from pmeier

Assignees
No one assigned
Labels
cla signed enhancement module: datasets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support compact/encoded RLE masks in COCO dataset wrapper
2 participants
@NicolasHug @facebook-github-bot