Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

undocumented breaking change - ref methods focus & blur missing #409

Open
szamanr opened this issue Apr 14, 2022 · 0 comments
Open

undocumented breaking change - ref methods focus & blur missing #409

szamanr opened this issue Apr 14, 2022 · 0 comments

Comments

@szamanr
Copy link

szamanr commented Apr 14, 2022

i upgraded from 4.3.0 to 4.8.0. as you can see in the diff, the focus and blur methods are no longer exposed, so i'm getting errors when trying to use it like:

import ReactTreeSelect from "rc-tree-select";

const ref = createRef<ReactTreeSelect>();
...
selectViewsRef.current.focus()

this is a breaking change in a minor version upgrade. please follow semver and do not introduce breaking changes in non-major upgrades. also, as far as i can tell, this change is not documented anywhere in the changelog / release notes. please document it.

for now i'll be pinning 4.3.0 and looking for an alternative library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant