fix: remove _JAVA_OPTIONS parameter & environment #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have checked |
cortinico
approved these changes
Jul 15, 2023
|
Indeed. Is there anything else worth updating as part of a breaking change? Could bump the default for |
|
Also worth noting for this PR that |
|
Do I need to do anything so that the semver bot understands the breaking change? |
Yup we use So your PR/Commit message should be updated |
fotos
force-pushed
the
no-java-options-env
branch
2 times, most recently
from
161f3c1
to
ffa8a10
Compare
|
Can this PR get merged? |
fotos
force-pushed
the
no-java-options-env
branch
from
ffa8a10
to
d737af9
Compare
react-native-circleci-orb-bot
pushed a commit
that referenced
this pull request
May 23, 2024
# [8.0.0](v7.4.0...v8.0.0) (2024-05-23) ### Bug Fixes * remove _JAVA_OPTIONS parameter & environment (closes [#171](#171)) ([d737af9](d737af9)) * Merge pull request #172 from devnev/no-java-options-env ([a7d373e](a7d373e)), closes [#172](#172) ### BREAKING CHANGES * The java_options parameter has been removed. Specify your JVM options in the gradle.properties file or in the gradle_options with -Dorg.gradle.jvmargs= instead.
|
🎉 This PR is included in version 8.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users should set org.gradle.jvmargs in their gradle.properties instead.
This fixes #171 where build failures caused by the unexpected output from java commands.
BREAKING CHANGE: The
java_optionsparameter has been removed. Specify your JVM options in thegradle.propertiesfile or in thegradle_optionswith-Dorg.gradle.jvmargs=instead.