Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bundle command usage #71

Open
andreialecu opened this issue Aug 1, 2020 · 1 comment
Open

bundle command usage #71

andreialecu opened this issue Aug 1, 2020 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@andreialecu
Copy link

andreialecu commented Aug 1, 2020

Apologies as this is more of an usage question (or a documentation request). I noticed a bundle command was added in #8 but there was no context as to what it is useful for.

The CircleCI landing page specifies that the dev tools could be used in Linux https://circleci.com/circleci-react/

My understanding is that the react-native bundle command could be used in Linux containers and a MacOS container would then just need to compile via xcode and skip the JS bundling altogether, thus saving on some of the time required to keep mac VMs online.

I suspect running the bundle command may help with that. The js bundle would need to be sent to the MacOS runner, and a SKIP_BUNDLING=true env variable might be needed (as per https://github.com/facebook/react-native/blob/master/scripts/react-native-xcode.sh#L30) so that XCode doesn't bundle it itself.

None of this seems to be documented anywhere though. 😕

Am I on the right track?

@vonovak vonovak added the help wanted Extra attention is needed label Mar 24, 2021
@fotos
Copy link
Collaborator

fotos commented Feb 12, 2024

@andreialecu I can't find recent documentation but in older versions of React Native there was a recommendation to bundle (manually) before building the app.

Nowadays all I found was this blog post that mentions the steps:

Older versions of React Native’s docs (0.19) recommended running the bundling command manually before building your app if you don’t have a react.gradle file.

What you have in mind is described in the documentation too:

The static bundle is built every time you target a physical device, even in Debug. If you want to save time, turn off bundle generation in Debug by adding the following to your shell script in the Xcode Build Phase Bundle React Native code and images.

Have you accomplished the above? Was it worth it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants