Skip to content
This repository has been archived by the owner on Nov 20, 2020. It is now read-only.

Make compatibility with reason-apollo optional #34

Open
fakenickels opened this issue Sep 6, 2019 · 6 comments
Open

Make compatibility with reason-apollo optional #34

fakenickels opened this issue Sep 6, 2019 · 6 comments

Comments

@fakenickels
Copy link
Member

Currently we require reason-apollo to be installed along with reason-apollo-hooks to ease the transition, now we can drop it and make this optional

@MargaretKrutikova
Copy link
Collaborator

That would be very nice!
There are however some useful bindings that come with reason-apollo, particularly when it comes to working with cache. ApolloClient had WriteQuery and ReadQuery for this (which could actually benefit from some improvements..) Do you think we should create our own bindings for those?

@cem2ran
Copy link

cem2ran commented Sep 9, 2019

I think it makes sense! Ideally we should split the bindings like react-apollo repo. common, components, hoc, hooks. Then there's react-apollo which has all of them.
https://github.com/apollographql/react-apollo/tree/master/packages

@fakenickels
Copy link
Member Author

That would be much better indeed @cem2ran, I think I can talk with @Gregoirevda about this. It'll scale much better

@Gregoirevda
Copy link

Sure, let's do that

@jfrolich
Copy link
Member

With Apollo Client 3.0 deprecating the react-apollo package, and the reason-apollo bindings not really being updated, isn't it better to make this package self-containing? Include the read/write query code and some of the types in this package. This also means we can easily update to the Apollo Client 3.0 beta.

@fakenickels
Copy link
Member Author

We could probably make this repo a monorepo and have a separated package for apollo-client

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants