with_namespace does not seem to be applying the namespace to pipelined commands with redis > 4.5.1

[alex-jobber]

Hello! I was recently looking into updating our redis gem past 4.5.1 and noticed that when using the updated pipelined syntax the namespace was not applied. I tried this with redis-store 1.9.0, 1.9.1, and 1.9.2.

It's possible we are no longer using redis-pool as intended, and if so would appreciate direction on that (this comment makes me think so but I am not sure).

Stripping away as much as possible (including additional commands inside the pipelined block) this is essentially what we are doing. The call to incrby (and other commands inside the pipelined block) does not include the namespace. ConnectionPool

redis_conn = proc { Redis::Store.new options }
redis_pool = ConnectionPool.new(
  size: pool_size,
  &redis_conn
)

redis_pool.with do |connection|
  connection.with_namespace(CACHE_NAMESPACE) do |namespaced_connection|
    namespaced_connection.pipelined do |pipeline|
      pipeline.incrby(key, amount)
    end
  end
end

Previously we would use the namespaced_connection directly inside the pipelined block, but that is now deprecated.

redis_pool.with do |connection|
  connection.with_namespace(CACHE_NAMESPACE) do |namespaced_connection|
    namespaced_connection.pipelined do
      namespaced_connection.incrby(key, amount)
    end
  end
end

I figured out we couldn't go past redis 4.5.1 with testing and when I was looking at this line, but I am not entirely sure how I could get namespacing applied to a pipelined block.