Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strategy for visible errors with Rxjs #573

Open
jondot opened this issue Sep 22, 2018 · 3 comments
Open

Strategy for visible errors with Rxjs #573

jondot opened this issue Sep 22, 2018 · 3 comments

Comments

@jondot
Copy link
Contributor

jondot commented Sep 22, 2018

Hi,
I find errors very hard to troubleshoot mainly because rxjs will silently swallow and "fix" them (with the tryCatch wrapper, removing handlers etc. This renders some epics dormant without any visible error to indicate)
https://github.com/ReactiveX/rxjs/blob/01a09789a0a9484c368b7bd6ed37f94d25490a00/src/internal/util/tryCatch.ts

Other than activating break on exceptions, do anyone have a better workflow?

@jayphelps
Copy link
Member

Hey 👋 oh no! In RxJS v6 errors should never be truly swallowed. Can you clarify what versions of redux-observable and rxjs you’re using and ideally provide way to reproduce?

@jondot
Copy link
Contributor Author

jondot commented Sep 22, 2018

Both latest as of today. In fact I’m upgrading from 5 to 6 and so I’m quite sure.
I’ll try to make an example

@Sawtaytoes
Copy link

I had to backtrack to RxJS v5.6-forward-compat because of issues with RxJS v6 and this was another one of those issues I ran into.

I was definitely having problems getting catchError to function like it used to. It was as if having a catchError didn't stop the entire observable from firing the error function on the subscriber. Is that the issue you were seeing too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants