Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redux-observable + next SSR memory leak #582

Open
xiaoDC opened this issue Oct 30, 2018 · 3 comments
Open

redux-observable + next SSR memory leak #582

xiaoDC opened this issue Oct 30, 2018 · 3 comments

Comments

@xiaoDC
Copy link

xiaoDC commented Oct 30, 2018

redux-observable + next SSR, it happens memory leak

I think it is a bug of redux-observable@1.0.0

I use next@6.1.1 SSR, and redux-observable@1.0.0 as redux-middleware, and i found more times visited the pages, the pages will cost more time to load the pages! And the server memory leak.

So i use heapdump package to get the memory info to this application.

the 1.heapsnapshot is the first visiting of the page, the 30.heapsnapshot is the last.

1.heapsnapshot
30.heapsnapshot

I use devtool load the heapsnapshots and I found the result is

Then i use redux-observable@0.19.0, the memory leak not happed!

@xiaoDC
Copy link
Author

xiaoDC commented Nov 6, 2018

@jacobpenny can you fix the bug?

@jayphelps
Copy link
Member

Hey there thanks for reporting. What’s the easiest way to reproduce this? Can you provide runnable code that reproduces it? I don’t have a SSR app handy and the couple of apps I know in the community haven’t seen this issue yet, but they may be doing something different.

@jayphelps
Copy link
Member

Love the heapdumps btw 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants