Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linked documentation in warning is not found #695

Open
dance2die opened this issue Nov 26, 2019 · 4 comments
Open

Linked documentation in warning is not found #695

dance2die opened this issue Nov 26, 2019 · 4 comments
Labels

Comments

@dance2die
Copy link

dance2die commented Nov 26, 2019

EDIT BY @jayphelps: Google killed the link, but I believe it pointed to the original issue ticket here: #389


Description

The link, https://goo.gl/2GQ7Da in warning does not exist.
(Error occurs even with all ad-blockers turned off)

image

The warning below is found here - https://github.com/redux-observable/redux-observable/blob/16f083d405/src/createEpicMiddleware.ts#L49

warn(
  'this middleware is already associated with a store. createEpicMiddleware should be called for every store.\n\nLearn more: https://goo.gl/2GQ7Da'
);

image

Additional Context

These are not directly related but added for completeness.

  • Redux-Observable version: v1.2.0
  • Site framework: Next.js v9.1.4
  • OS: Windows 10 build 1903.
  • Browser: All browsers (Used Brave in the screenshot)

Searching for https://goo.gl/2GQ7Da in the issue shows Server Side Rendering Documentation (not a dupe), which I will be checking out for the warning.

@dance2die dance2die changed the title Linked documentation in warning is not available Linked documentation in warning is not found Nov 26, 2019
@jayphelps
Copy link
Member

Oh bummer. Google stopped supporting their old shortened links and it's now a Firebase thing. Thanks for the heads up! The next release will fix the warnings, though unfortunately it doesn't seem like I can retroactively fix the old ones. 😢

@dance2die
Copy link
Author

You're welcome & thank you for looking into the matter~

@vvscode
Copy link

vvscode commented Jun 11, 2020

+1 for the issue - how about the fix? at least post the correct link here ))

@jayphelps
Copy link
Member

I'm not sure what that link pointed to unfortunately since Google killed them. It might have pointed to the original issue ticket: #389

The solution depends on exactly what you're doing, but the most general description of the solution is that you (currently) cannot reuse an epic middleware with more than one store, you have to call createEpicMiddleware() and run the root epic each time you create a new store.

While testing epics using a mock redux store isn't wrong--feel free to continue to do so--you might consider testing epics using the RxJS TestScheduler with marble diagrams, instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants