Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using with Redux-toolkit v2? #788

Open
F-happy opened this issue Dec 6, 2023 · 13 comments
Open

Using with Redux-toolkit v2? #788

F-happy opened this issue Dec 6, 2023 · 13 comments

Comments

@F-happy
Copy link

F-happy commented Dec 6, 2023

No description provided.

@evertbouw
Copy link
Member

Once we've published a compatibility update you can use Redux-Observable with Redux-toolkit like this https://github.com/evertbouw/vite-template-redux-observable

@ratoaq2
Copy link

ratoaq2 commented Dec 14, 2023

will there be a release supporting the new redux major version?

@evertbouw
Copy link
Member

If you aren't using typescript it should work with the existing version. I made the code changes so I think it's ready, but afaik only @jayphelps has the permissions to publish. I could publish a candidate under my own scope if you'd be ok using that.

@jayphelps
Copy link
Member

jayphelps commented Dec 14, 2023

@evertbouw I've now added you to npm. Otherwise I should have time to do the publish next week when I'm off work. Busy times at work right now.

@evertbouw
Copy link
Member

Ok I'll publish a release candidate later tonight

@evertbouw
Copy link
Member

Published RC2 and brought the template under the redux-observable org https://github.com/redux-observable/vite-template-redux-observable

@glarget
Copy link

glarget commented Jan 2, 2024

Hi, I have a question about RTK V2, Redux V5 and React-redux V9 please.

With the new migration guide here https://redux.js.org/usage/migrations/migrating-rtk-2, I followed the instructions and I use redux-observable v2.

While yarn install, I saw this warning: "> redux-observable@2.0.0" has incorrect peer dependency "redux@>=4 <5".

Could my application be stable with redux-observable 2.0 combined with all the latest redux / RTK versions ?

If no:

  • Could I install your new 3.0.0-rc2 version and go in production with it ?

Thank you very much for your help !

@evertbouw
Copy link
Member

@glarget yes you can install 3.0.0-rc2. I've not received any bug reports so I should publish 3.0.0 soon without any changes.

@azangru
Copy link

azangru commented Jan 22, 2024

It's been 3 weeks since the last comment. When will soon come? 🥺

@azangru
Copy link

azangru commented Feb 20, 2024

It's been a month and a half now... 😞

@jayphelps
Copy link
Member

@azangru entitlement in open source isn't a good look. Use some other library or make your own if this is bothering you.

@jayphelps
Copy link
Member

@azangru What I said was a bit harsh, I'm sorry about that. Said another way: we (the maintainers) are volunteers and none of us actually work on any apps that use Redux Observable at the moment. I don't even maintain any UI application right now as part of my job. So it's hard to find time, and for me specifically it's hard to find motivation to make the time because I haven't really enjoyed doing open source for many years after being burnt out from people's thankless demands. In this case 3.0.0-rc2 is available, so it's frustrating to see your comments which imply something is blocking you, when I don't believe anything is?

@evertbouw
Copy link
Member

tagging a new version number doesn't really change anything but it can go wrong, so I need to take the time for this and actually do it. Getting the website in order is a higher priority for me but would take even more time. Having the latest tagged as 'release candidate' hopefully directs people to the git repo for the latest information.

the release candidate is stable, please use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants