Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to callback additional diff-engine with decoded images data #14

Open
Quramy opened this issue Nov 16, 2017 · 0 comments · May be fixed by #15
Open

Ability to callback additional diff-engine with decoded images data #14

Quramy opened this issue Nov 16, 2017 · 0 comments · May be fixed by #15
Labels
enhancement

Comments

@Quramy
Copy link
Member

Quramy commented Nov 16, 2017 •
edited

Motivation

I'm working on https://reg-viz.github.io/x-img-diff-js and want to integrate it to reg's toolchain.

x-img-diff-js requires decoded input images such as:

const image = {
  width: 100,
  height: 100,
  data: new Uint8Array(buffer),  // 32-bit 10K sized array
}

For now, img-diff-js has responsibility to decode PNG/JPEG/etc images to canonical(the above) format, so it's nice to pass decoded data to the additional diff-engines.
@Quramy Quramy linked a pull request Nov 16, 2017 that will close this issue
Open
@Quramy Quramy changed the title Ability to call additional diff-engine with decoded images data Ability to callback additional diff-engine with decoded images data Nov 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prehook reg-viz/img-diff-js
1 participant
@Quramy