update: return non-0 exit code for compare w/changes #591

maniator · 2022-08-11T20:56:54Z

What does this change?

makes this line: https://github.com/reg-viz/reg-suit/blob/master/packages/reg-suit-cli/src/cli.ts#L94 throw a promise error which is caught at the end of the file to have the error code be 1 instead of zero

References

Closes #505

maniator · 2022-08-11T22:46:25Z

packages/reg-suit-cli/src/commands/compare.ts

@@ -4,7 +4,13 @@ import getRegCore from "../get-reg-core";
 async function compare(options: CliOptions) {
  const processor = getRegCore(options).createProcessor();
  const ctx = await processor.getExpectedKey();
-  await processor.compare(ctx);
+  const { comparisonResult } = await processor.compare(ctx);
+  const numberOfFailed = comparisonResult.failedItems.length;


we may also want to fail if there are new items or deleted, but I did not do that for now

update: return non-0 exit code for compare w/changes

8149cd1

Closed reg-viz#505

maniator mentioned this pull request Aug 11, 2022

Non-0 exit code when comparison detects changes #505

Open

maniator commented Aug 11, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update: return non-0 exit code for compare w/changes #591

update: return non-0 exit code for compare w/changes #591

maniator commented Aug 11, 2022 •

edited

maniator Aug 11, 2022

update: return non-0 exit code for compare w/changes #591

Are you sure you want to change the base?

update: return non-0 exit code for compare w/changes #591

Conversation

maniator commented Aug 11, 2022 • edited

What does this change?

References

maniator Aug 11, 2022

Choose a reason for hiding this comment

maniator commented Aug 11, 2022 •

edited