Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Everything breaks if IsLocal already exists in the animator as a bool (rework) #26

Open
SenkyDragon opened this issue Feb 2, 2024 · 2 comments

Comments

@SenkyDragon
Copy link

SenkyDragon commented Feb 2, 2024

If IsLocal is already used as a boolean in the controller, OSCmooth should not add it as an additional float parameter as the duplicate parameter breaks the controller. If the type must be a float, and the controller already contains it as a bool, OSCsmooth MUST not only update the type of the existing parameter, it must also walk the entire controller (including sub-state machines) updating the type of every transition condition using IsLocal to swap it from a boolean condition to a float condition.

@SenkyDragon
Copy link
Author

Issue reported by a user in the vrcfury discord.

@SenkyDragon SenkyDragon changed the title Everything breaks if IsLocal already exists in the animator as a type other than bool Everything breaks if IsLocal already exists in the animator as a bool (rework) Feb 2, 2024
@regzo2
Copy link
Owner

regzo2 commented Feb 5, 2024

Will be fixed for release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants