Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove or upgrade prettier dependency #2250

Open
dgtllion opened this issue Apr 10, 2024 · 1 comment · May be fixed by #2255
Open

Remove or upgrade prettier dependency #2250

dgtllion opened this issue Apr 10, 2024 · 1 comment · May be fixed by #2255
Labels
type: bug 🪲 Something isn't working

Comments

@dgtllion
Copy link

Summary

When i try to install packages with pnpm and have prettier in my package.json as a dependency i get a warning from a package manager that the versions are unmet.

Steps to reproduce

pnpm add prettier && pnpm add remirror @remirror/react

Expected results

no warning when trying to add with pnpm

Actual results

 WARN  Issues with peer dependencies found
.
├─┬ @remirror/react 2.0.35
│ └─┬ @remirror/extension-react-tables 2.2.19
│ └─┬ @remirror/react-components 2.1.17
│ └─┬ @remirror/extension-code-block 2.0.18
│ └── ✕ unmet peer prettier@^2.8.8: found 3.2.5
└─┬ remirror 2.0.39
└── ✕ unmet peer prettier@^2.8.8: found 3.2.5

@dgtllion dgtllion added the type: bug 🪲 Something isn't working label Apr 10, 2024
@dgtllion dgtllion changed the title Remove prettier dependency Remove or upgrade prettier dependency Apr 10, 2024
@mdmower
Copy link

mdmower commented May 25, 2024

The problem is more severe when using npm instead of pnpm.

package.json

{
  "name": "my-project",
  "version": "1.0.0",
  "dependencies": {
    "prettier": "^3.2.5",
    "remirror": "^2.0.39"
  }
}

npm install (using node v20.13.1 and npm 10.8.0)

npm warn ERESOLVE overriding peer dependency
npm error code ERESOLVE
npm error ERESOLVE could not resolve
npm error
npm error While resolving: remirror@2.0.39
npm error Found: prettier@3.2.5
npm error node_modules/prettier
npm error   peerOptional prettier@"^2.8.8" from @remirror/extension-code-block@2.0.18
npm error   node_modules/remirror/node_modules/@remirror/extension-code-block
npm error     @remirror/extension-code-block@"^2.0.18" from remirror@2.0.39
npm error     node_modules/remirror
npm error       remirror@"^2.0.39" from the root project
npm error
npm error Could not resolve dependency:
npm error peerOptional prettier@"^2.8.8" from remirror@2.0.39
npm error node_modules/remirror
npm error   remirror@"^2.0.39" from the root project
npm error
npm error Conflicting peer dependency: prettier@2.8.8
npm error node_modules/prettier
npm error   peerOptional prettier@"^2.8.8" from remirror@2.0.39
npm error   node_modules/remirror
npm error     remirror@"^2.0.39" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.
npm error
npm error
npm error For a full report see:
npm error /home/mdmower/.npm/_logs/2024-05-25T05_31_30_856Z-eresolve-report.txt
npm error A complete log of this run can be found in: /home/mdmower/.npm/_logs/2024-05-25T05_31_30_856Z-debug-0.l

@mdmower mdmower linked a pull request May 26, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🪲 Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants