Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark theme inline code links are completely indistinguishable from non-link inline code #260

Closed
kisaragi-hiu opened this issue May 13, 2024 · 0 comments · Fixed by #262
Closed

Comments

@kisaragi-hiu
Copy link
Contributor

In dark mode, inline code links (links that only contain inline code, like this) look identical to inline code that isn't a link.

Dark theme Light theme
Dark mode screenshot of the .client modules page in Remix documentation, with two handdrawn arrows, one pointing to "useEffect" and is labeled "link", another pointing to ".client" and is labeled "not a link". The two texts being pointed to otherwise appear identical in style. Light mode screenshot of the .client modules page in Remix documentation. There are no handdrawn arrows. The same texts corresponding to the texts in the dark mode screenshot are visually distinct.

Reproduction:

  • Visit a page that has both non-link inline code and inline code links (links that only contain inline code like this)
  • Switch to dark mode if not already in dark mode
  • Try to figure out if an inline code element is a link or not, and notice that it's a lot harder without the visual distinction.

This reproduces on both Firefox and Chromium.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant