Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README regarding Targetted Catch blocks. #45

Open
jeremy-j-ackso opened this issue May 3, 2019 · 0 comments
Open

Update README regarding Targetted Catch blocks. #45

jeremy-j-ackso opened this issue May 3, 2019 · 0 comments

Comments

@jeremy-j-ackso
Copy link

The README says:

Everything applies to request-promise-native except the following:

  • Instead of using Bluebird promises this library uses native ES6 promises.
  • Mind that native ES6 promises have fewer features than Bluebird promises do. In particular, the .finally(...) method is not available.

And for somebody unfamiliar with Bluebird promises, it is not immediately obvious that native Promises do not support targeted catch blocks. Somebody (like me) might just think it's a little-known feature of Promises and end up banging their head on things until they eventually find this:
#15 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant