Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove file encoding guessing from DATFile #21

Open
2 tasks
pixeldesu opened this issue Jun 2, 2019 · 0 comments
Open
2 tasks

Remove file encoding guessing from DATFile #21

pixeldesu opened this issue Jun 2, 2019 · 0 comments
Labels
PangLib.DAT Issues regarding PangLib.DAT PangLib.Utilities Issues regarding PangLib.Utilities refactoring Refactor related issues

Comments

@pixeldesu
Copy link
Member

With using Stream in the constructor we can't even pass a file name anymore, aside that we've been guessing it anyway.

Move guessing of encoding to PangLib.Utilities instead, so people don't have to search for the encodings themself.

To Do:

  • Add Encoding to DATFile constructor
  • Move GetEncodingFromFileName to a static helper inside PangLib.Utilities
@pixeldesu pixeldesu added PangLib.DAT Issues regarding PangLib.DAT PangLib.Utilities Issues regarding PangLib.Utilities refactoring Refactor related issues labels Jun 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PangLib.DAT Issues regarding PangLib.DAT PangLib.Utilities Issues regarding PangLib.Utilities refactoring Refactor related issues
Projects
None yet
Development

No branches or pull requests

1 participant