Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use latest staticcheck version (or/and support specifying staticcheck version) #17

Open
haya14busa opened this issue Mar 7, 2021 · 0 comments

Comments

@haya14busa
Copy link
Member

This is a follow-up to #16.

It's safer to use a fixed staticcheck version and automate updating it with depup instead of installing the latest version.

Optionally, we can also support specifying the staticcheck version as an action input.
Personally, I don't like this option so much because ...

  1. Generally it's good to use the latest version so that users can enjoy the latest improved version of staticcheck.
  2. Most users won't notice and could forget the new version of staticcheck if we put this as an action input. Users can use action-depup to update the staticcheck version input, but probably it's too much work.
  3. It would be hard to maintain the script in this action. Suppose a new staticcheck introduced new flags or breaking changes, it's difficult to update the script if users pass an old version as the input.

Users can still pin the action-staticcheck version to pin staticcheck version or they can manually install staticcheck and reviewdog if they want to stick with an old version.

cc/ @kstiehl @dominikh

@kstiehl, I'd appreciate it if you want to work on this issue but I'll leave it to you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant