側の実装 #73
Merged
側の実装 #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CityBear3
reviewed
Jun 16, 2023
backend/domain/model/user.go
Outdated
|
|
||
| type UserService interface { | ||
| GetUser() | ||
| GetUsers() |
There was a problem hiding this comment.
[IMO] ここのinterfaceは無くても問題ない気がしますがどうでしょうか？
CityBear3
reviewed
Jun 16, 2023
|
たとえばどんな名前にしたほうがいいですか？ |
1uf3
force-pushed
the
feature-71-UserServiceServer
branch
from
7158ac1
to
186665e
Compare
CityBear3
reviewed
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close: #71
内部実装はない模様