Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Allow fractional shares (no rounding) in discrete allocation (post-processing) #559

Open
yujinio opened this issue Aug 27, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@yujinio
Copy link

yujinio commented Aug 27, 2023

Is your feature request related to a problem?
Somewhat (see below for more info).

Describe the feature you'd like
Market allows to purchase fractional shares (e.g. crypto). Currently implemented post-processing methods in discrete_allocation.DiscreteAllocation do not allow that - they by default do rounding without option to disable that.
The idea is to include an argument rounding: bool or similar that allows to either do rounding or not while doing post-processing discrete allocation.

Additional context
None.

@yujinio yujinio added the enhancement New feature or request label Aug 27, 2023
@88d52bdba0366127fffca9dfa93895
Copy link
Collaborator

This is great suggestion, maybe you could do it by yourself then open the PR, or you could wait for the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants